support training bloom-560m and load dataset from local dir #678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzg0601
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
arashb,
awan-10,
conglongli,
duli2012,
eltonzheng,
jeffra,
minjiaz,
mrwyattii,
samyam,
tjruwase,
xiaoxiawu-microsoft and
yaozhewei
as code owners
Author
|
@microsoft-github-policy-service agree |
Contributor
|
@hzg0601 Before reviewing this PR, we need your help on two things: (1) Why your PR is deleting this log file? https://github.com/microsoft/DeepSpeedExamples/blob/04b1036349b0d02e0f940c8431414ef18e96ddf2/applications/DeepSpeed-Chat/training/step1_supervised_finetuning/training_log_output/opt-1.3b-globalBatchSize128.log If this is by mistake, please restore it. If this is not by mistake, please give a clear reason of why deleting it. (2) The formatting test is failing. Please follow my comment at here #597 (comment) to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those who can't access huggingface hub stably, they have to download the repo of huggingface hub manually and
upload dataset in the offline mode. However, current implementation use the model_name as the key to load corresponding dataset class of
raw_datasets.pywhich would raiseRuntimeError( f"We do not have configs for dataset {dataset_name}, but you can add it by yourself in raw_datasets.py." ). This PR fix the problem by split the string of local path.argsin case of that situation.